Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1589)

Unified Diff: fpdfsdk/src/jsapi/fxjs_v8.cpp

Issue 1351173002: XFA: contention between FXJSE and FXJS over isolate data slots (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/src/jsapi/fxjs_v8.cpp
diff --git a/fpdfsdk/src/jsapi/fxjs_v8.cpp b/fpdfsdk/src/jsapi/fxjs_v8.cpp
index 135b5e93498c19c5e839c76f14a73f0d2049e96e..4634f1baa951b178e8052e950a2efb90ec69e0c7 100644
--- a/fpdfsdk/src/jsapi/fxjs_v8.cpp
+++ b/fpdfsdk/src/jsapi/fxjs_v8.cpp
@@ -273,8 +273,6 @@ void JS_InitializeRuntime(v8::Isolate* pIsolate,
v8::Local<v8::ObjectTemplate>::New(pIsolate, globalObjTemp));
v8::Context::Scope context_scope(v8Context);
- // v8::Local<External> ptr = External::New(isolate, pFXRuntime);
- // v8Context->SetEmbedderData(1, ptr);
// TODO(tsepez): Don't use more than one embedder data slot.
pIsolate->SetData(2, pFXRuntime);
@@ -349,7 +347,6 @@ void JS_ReleaseRuntime(v8::Isolate* pIsolate,
}
delete pArray;
- pIsolate->SetData(1, NULL);
pIsolate->SetData(g_embedderDataSlot, NULL);
// TODO(tsepez): Don't use more than one embedder data slot.
pIsolate->SetData(2, NULL);

Powered by Google App Engine
This is Rietveld 408576698