XFA: contention between FXJSE and FXJS over isolate data slots

fpdfsdk/src/jsapi/fxjs_v8.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../core/include/fxcrt/fx_basic.h"
 #include "../../../core/include/fxcrt/fx_ext.h"
 #include "../../include/jsapi/fxjs_v8.h"
 #include "../../include/fsdk_define.h"
@@ skipping 255 matching lines @@
   v8::Locker locker(pIsolate);
   v8::HandleScope handle_scope(pIsolate);
 
   v8::Global<v8::ObjectTemplate>& globalObjTemp =
       _getGlobalObjectTemplate(pIsolate);
   v8::Local<v8::Context> v8Context = v8::Context::New(
       pIsolate, NULL,
       v8::Local<v8::ObjectTemplate>::New(pIsolate, globalObjTemp));
   v8::Context::Scope context_scope(v8Context);
 
-  // v8::Local<External> ptr = External::New(isolate, pFXRuntime);
-  // v8Context->SetEmbedderData(1, ptr);
   // TODO(tsepez): Don't use more than one embedder data slot.
   pIsolate->SetData(2, pFXRuntime);
 
   CFX_PtrArray* pArray = (CFX_PtrArray*)pIsolate->GetData(g_embedderDataSlot);
   if (!pArray)
     return;
 
   for (int i = 0; i < pArray->GetSize(); i++) {
     CJS_ObjDefintion* pObjDef = (CJS_ObjDefintion*)pArray->GetAt(i);
     CFX_WideString ws = CFX_WideString(pObjDef->objName);
@@ skipping 54 matching lines @@
       v8::Local<v8::Object> pObj =
           v8::Local<v8::Object>::New(pIsolate, pObjDef->m_StaticObj);
       if (pObjDef->m_pDestructor)
         pObjDef->m_pDestructor(pObj);
       JS_FreePrivate(pObj);
     }
     delete pObjDef;
   }
   delete pArray;
 
-  pIsolate->SetData(1, NULL);
   pIsolate->SetData(g_embedderDataSlot, NULL);
   // TODO(tsepez): Don't use more than one embedder data slot.
   pIsolate->SetData(2, NULL);
 }
 
 void JS_Initialize(unsigned int embedderDataSlot) {
   g_embedderDataSlot = embedderDataSlot;
 }
 
 void JS_Release() {
@@ skipping 747 matching lines @@
 
 bool JS_PortIsNan(double d) {
   return d != d;
 }
 
 double JS_LocalTime(double d) {
   return JS_GetDateTime() + _getDaylightSavingTA(d);
 }
 
 // JavaScript time implement End.