XFA: contention between FXJSE and FXJS over isolate data slots

fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp

Index: fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp
diff --git a/fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp b/fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp
index 8f8084be5751340587f30f57de0e60c2fe71a08f..499112407fa036de002a5c81bf34ba1f6ff3528f 100644
--- a/fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp
+++ b/fpdfsdk/src/fpdfxfa/fpdfxfa_app.cpp
@@ -33,7 +33,7 @@ CJS_RuntimeFactory* g_GetJSRuntimeFactory() {
 }
 
 CPDFXFA_App::CPDFXFA_App()
-    : m_bInitRuntime(FALSE),
+    : m_bJavaScriptInitialized(FALSE),
       m_pXFAApp(NULL),
       m_pFontMgr(NULL),
       m_hJSERuntime(NULL),
@@ -78,18 +78,6 @@ FX_BOOL CPDFXFA_App::Initialize() {
   return TRUE;
 }
 
-FX_BOOL CPDFXFA_App::InitRuntime(FX_BOOL bReset) {
-  if (bReset) {
-    m_bInitRuntime = FALSE;
-    return TRUE;
-  }
-  if (m_bInitRuntime) {
-    return TRUE;
-  }
-  m_bInitRuntime = TRUE;
-  return FALSE;
-}
-
 FX_BOOL CPDFXFA_App::AddFormFillEnv(CPDFDoc_Environment* pEnv) {
   if (!pEnv)
     return FALSE;
@@ -110,10 +98,6 @@ FX_BOOL CPDFXFA_App::RemoveFormFillEnv(CPDFDoc_Environment* pEnv) {
 
   return FALSE;
 }
-void CPDFXFA_App::ReleaseRuntime() {
-  v8::Global<v8::Context> context;
-  JS_ReleaseRuntime((v8::Isolate*)m_hJSERuntime, context);

[Tom Sepez, 2015/09/17 21:58:39]

Different segv, can't pass NULL ctx here. Already taken care of elsewhere.

-}
 
 void CPDFXFA_App::GetAppType(CFX_WideString& wsAppType) {
   wsAppType = m_csAppType;