Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 1351143005: mac: Remove a few symbols from framework.order (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Remove a few symbols from framework.order We don't support NPAPI any more, so we don't export the NPAPI symbols. I'm not sure why we needed the two narrowPrecision lines, but they've been here since this file got added and I don't see them anymore in my local build, so they're probably safe to remove. (If not, please revert this CL and point me to a bot where they're needed.) The NaCl symbols have been marked as hidden since https://codereview.chromium.org/293009 (which landed before the CL that added the two NaCl lines to this file, https://codereview.chromium.org/464046 – but the motivation in that CL is a coverage build, which we don't have anymore anyways). In the same vein, remove all the gcov symbols since we don't have a code coverage build any more. If needed, we can add them back later. Also remove _catch_exception_raise which was needed for breakpad. Now that we use crashpad, this shouldn't be necessary. No intended behavior change. BUG=none Committed: https://crrev.com/221bdb216bfeb84445ba9d90652a00e470c4690b Cr-Commit-Position: refs/heads/master@{#349761}

Patch Set 1 #

Patch Set 2 : nacl #

Total comments: 4

Patch Set 3 : actually upload #

Patch Set 4 : bleh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -29 lines) Patch
M chrome/app/framework.order View 1 2 3 1 chunk +0 lines, -29 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Nico
5 years, 3 months ago (2015-09-18 19:40:53 UTC) #2
Mark Mentovai
LGTM, but maybe you can be even more aggressive. OK to split it up if ...
5 years, 3 months ago (2015-09-18 20:15:11 UTC) #3
Nico
Thanks, I removed those too.
5 years, 3 months ago (2015-09-18 20:23:09 UTC) #4
Nico
https://codereview.chromium.org/1351143005/diff/20001/chrome/app/framework.order File chrome/app/framework.order (right): https://codereview.chromium.org/1351143005/diff/20001/chrome/app/framework.order#newcode21 chrome/app/framework.order:21: __ZnwmPv On 2015/09/18 20:15:10, Mark Mentovai - August is ...
5 years, 3 months ago (2015-09-18 20:24:08 UTC) #5
Mark Mentovai
Cool. I’m less certain about operator new and operator delete also.
5 years, 3 months ago (2015-09-18 20:24:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351143005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351143005/20001
5 years, 3 months ago (2015-09-18 20:27:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351143005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351143005/60001
5 years, 3 months ago (2015-09-18 20:37:48 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 3 months ago (2015-09-18 20:49:26 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 20:50:06 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/221bdb216bfeb84445ba9d90652a00e470c4690b
Cr-Commit-Position: refs/heads/master@{#349761}

Powered by Google App Engine
This is Rietveld 408576698