Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1351013002: Revert of Mandoline UI Process: Update namespaces and file names (Closed)

Created:
5 years, 3 months ago by Nico
Modified:
5 years, 3 months ago
Reviewers:
Fady Samuel, sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mandoline UI Process: Update namespaces and file names (patchset #9 id:150001 of https://codereview.chromium.org/1340983002/ ) Reason for revert: Speculative, might've broken mojo_apptests on http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/32066 Original issue's description: > Mandoline UI Process: Update namespaces and file names > > This CL updates namespaces in components/mus to mus from mojo, surfaces, gles2, and view_manager. > > BUG=531533 > TBR=jam@chromium.org for trivial pdf_viewer change. > > Committed: https://crrev.com/49b0d73f3ebb4801fc518751145504af3a2f70ed > Cr-Commit-Position: refs/heads/master@{#349229} TBR=sky@chromium.org,fsamuel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=531533 Committed: https://crrev.com/35b19f7d5d7b7b68878d6c766e93e148f8b06998 Cr-Commit-Position: refs/heads/master@{#349332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1248 lines, -1255 lines) Patch
M components/html_viewer/ax_provider_apptest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/document_resource_waiter.h View 4 chunks +6 lines, -6 lines 0 comments Download
M components/html_viewer/document_resource_waiter.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/global_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/html_document.h View 5 chunks +6 lines, -6 lines 0 comments Download
M components/html_viewer/html_document.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M components/html_viewer/html_frame.h View 10 chunks +16 lines, -19 lines 0 comments Download
M components/html_viewer/html_frame.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M components/html_viewer/html_frame_apptest.cc View 5 chunks +4 lines, -6 lines 0 comments Download
M components/html_viewer/html_frame_tree_manager.h View 5 chunks +5 lines, -5 lines 0 comments Download
M components/html_viewer/html_frame_tree_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/html_widget.h View 6 chunks +8 lines, -11 lines 0 comments Download
M components/html_viewer/html_widget.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M components/html_viewer/ime_controller.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/html_viewer/ime_controller.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M components/html_viewer/web_layer_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/html_viewer/web_layer_impl.cc View 1 chunk +7 lines, -6 lines 0 comments Download
M components/html_viewer/web_layer_tree_view_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/html_viewer/web_layer_tree_view_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/access_policy.h View 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/access_policy_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/android_loader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/android_loader.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/client_connection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/client_connection.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/connection_manager.h View 10 chunks +21 lines, -20 lines 0 comments Download
M components/mus/connection_manager.cc View 6 chunks +12 lines, -9 lines 0 comments Download
M components/mus/connection_manager_delegate.h View 3 chunks +8 lines, -5 lines 0 comments Download
M components/mus/default_access_policy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/default_access_policy.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M components/mus/display_manager.h View 6 chunks +17 lines, -13 lines 0 comments Download
M components/mus/display_manager.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M components/mus/display_manager_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/display_manager_factory.h View 2 chunks +6 lines, -6 lines 0 comments Download
M components/mus/event_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/event_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/focus_controller.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/focus_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/focus_controller_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/focus_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gesture_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gesture_manager.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/gesture_manager_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gesture_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M components/mus/gles2/command_buffer_impl.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M components/mus/gles2/command_buffer_impl_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_local.h View 4 chunks +4 lines, -5 lines 0 comments Download
M components/mus/gles2/command_buffer_local.cc View 5 chunks +14 lines, -12 lines 0 comments Download
M components/mus/gles2/command_buffer_local_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/command_buffer_type_conversions.h View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gles2/command_buffer_type_conversions.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/gles2/gpu_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/gpu_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/gpu_memory_tracker.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/gles2/gpu_memory_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/gpu_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/gpu_state.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_buffer_backing.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_buffer_backing.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/gles2/mojo_gpu_memory_buffer_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ids.h View 3 chunks +10 lines, -9 lines 0 comments Download
M components/mus/main.cc View 1 chunk +2 lines, -6 lines 0 comments Download
D components/mus/mus_app.h View 1 chunk +0 lines, -100 lines 0 comments Download
D components/mus/mus_app.cc View 1 chunk +0 lines, -148 lines 0 comments Download
M components/mus/public/cpp/args.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/keys.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/keys.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/args.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/scoped_view_ptr.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/view.cc View 17 chunks +35 lines, -37 lines 0 comments Download
M components/mus/public/cpp/lib/view_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/view_private.h View 3 chunks +6 lines, -7 lines 0 comments Download
M components/mus/public/cpp/lib/view_private.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/view_surface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/view_tree_client_impl.h View 5 chunks +29 lines, -33 lines 0 comments Download
M components/mus/public/cpp/lib/view_tree_client_impl.cc View 17 chunks +37 lines, -41 lines 0 comments Download
M components/mus/public/cpp/lib/view_tree_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/lib/view_tree_host_factory.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M components/mus/public/cpp/scoped_view_ptr.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/run_all_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/view_manager_test_base.h View 3 chunks +11 lines, -13 lines 0 comments Download
M components/mus/public/cpp/tests/view_manager_test_base.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M components/mus/public/cpp/tests/view_manager_test_suite.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/view_manager_test_suite.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/tests/view_unittest.cc View 13 chunks +21 lines, -21 lines 0 comments Download
M components/mus/public/cpp/types.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/view.h View 7 chunks +17 lines, -18 lines 0 comments Download
M components/mus/public/cpp/view_observer.h View 3 chunks +11 lines, -11 lines 0 comments Download
M components/mus/public/cpp/view_property.h View 2 chunks +23 lines, -23 lines 0 comments Download
M components/mus/public/cpp/view_surface.h View 4 chunks +5 lines, -5 lines 0 comments Download
M components/mus/public/cpp/view_surface_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/view_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/view_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/view_tree_connection.h View 3 chunks +4 lines, -6 lines 0 comments Download
M components/mus/public/cpp/view_tree_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/public/cpp/view_tree_host_factory.h View 1 chunk +7 lines, -10 lines 0 comments Download
M components/mus/public/interfaces/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D components/mus/public/interfaces/mus_constants.mojom View 1 chunk +0 lines, -10 lines 0 comments Download
A components/mus/public/interfaces/view_manager_constants.mojom View 1 chunk +10 lines, -0 lines 0 comments Download
M components/mus/public/interfaces/view_tree.mojom View 1 chunk +1 line, -1 line 0 comments Download
M components/mus/server_view.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/server_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/server_view_delegate.h View 2 chunks +8 lines, -5 lines 0 comments Download
M components/mus/server_view_drawn_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/server_view_drawn_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/server_view_drawn_tracker_observer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/server_view_drawn_tracker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/server_view_observer.h View 3 chunks +4 lines, -4 lines 0 comments Download
M components/mus/surfaces/surfaces_context_provider.h View 2 chunks +9 lines, -6 lines 0 comments Download
M components/mus/surfaces/surfaces_context_provider.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M components/mus/surfaces/surfaces_context_provider_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_output_surface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_output_surface.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_scheduler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_scheduler.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_state.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/surfaces_state.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/mus/surfaces/top_level_display_client.h View 4 chunks +8 lines, -5 lines 0 comments Download
M components/mus/surfaces/top_level_display_client.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/mus/test_change_tracker.h View 5 chunks +23 lines, -22 lines 0 comments Download
M components/mus/test_change_tracker.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M components/mus/test_server_view_delegate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/test_server_view_delegate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/mus/view_coordinate_conversions.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_coordinate_conversions.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_coordinate_conversions_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_locator.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_locator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A components/mus/view_manager_app.h View 1 chunk +105 lines, -0 lines 0 comments Download
A components/mus/view_manager_app.cc View 1 chunk +146 lines, -0 lines 0 comments Download
M components/mus/view_manager_client_apptest.cc View 9 chunks +10 lines, -10 lines 0 comments Download
M components/mus/view_tree_apptest.cc View 14 chunks +33 lines, -35 lines 0 comments Download
M components/mus/view_tree_host_connection.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_tree_host_connection.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_tree_host_delegate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/view_tree_host_impl.h View 3 chunks +10 lines, -9 lines 0 comments Download
M components/mus/view_tree_host_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/view_tree_impl.h View 8 chunks +25 lines, -25 lines 0 comments Download
M components/mus/view_tree_impl.cc View 7 chunks +9 lines, -8 lines 0 comments Download
M components/mus/view_tree_unittest.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M components/mus/window_manager_access_policy.h View 2 chunks +4 lines, -4 lines 0 comments Download
M components/mus/window_manager_access_policy.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M components/pdf_viewer/pdf_viewer.cc View 10 chunks +16 lines, -14 lines 0 comments Download
M components/web_view/frame.h View 6 chunks +12 lines, -12 lines 0 comments Download
M components/web_view/frame.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M components/web_view/frame_apptest.cc View 9 chunks +11 lines, -11 lines 0 comments Download
M components/web_view/frame_tree.h View 2 chunks +2 lines, -2 lines 0 comments Download
M components/web_view/frame_tree.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/web_view/frame_tree_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/public/cpp/web_view.h View 2 chunks +1 line, -4 lines 0 comments Download
M components/web_view/public/cpp/web_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.h View 3 chunks +6 lines, -6 lines 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M components/web_view/web_view_apptest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/web_view/web_view_impl.h View 3 chunks +10 lines, -10 lines 0 comments Download
M components/web_view/web_view_impl.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M mandoline/services/core_services/application_delegate_factory_notandroid.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mandoline/ui/aura/aura_init.h View 2 chunks +1 line, -4 lines 0 comments Download
M mandoline/ui/aura/aura_init.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/aura/input_method_mandoline.h View 3 chunks +3 lines, -3 lines 0 comments Download
M mandoline/ui/aura/input_method_mandoline.cc View 1 chunk +1 line, -1 line 0 comments Download
M mandoline/ui/aura/native_widget_view_manager.h View 2 chunks +8 lines, -8 lines 0 comments Download
M mandoline/ui/aura/native_widget_view_manager.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M mandoline/ui/aura/surface_binding.h View 3 chunks +2 lines, -5 lines 0 comments Download
M mandoline/ui/aura/surface_binding.cc View 6 chunks +15 lines, -12 lines 0 comments Download
M mandoline/ui/aura/surface_context_factory.h View 3 chunks +2 lines, -5 lines 0 comments Download
M mandoline/ui/aura/surface_context_factory.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M mandoline/ui/aura/window_tree_host_mojo.h View 2 chunks +5 lines, -5 lines 0 comments Download
M mandoline/ui/aura/window_tree_host_mojo.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.h View 4 chunks +8 lines, -8 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M mandoline/ui/omnibox/omnibox_application.cc View 6 chunks +10 lines, -10 lines 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.h View 3 chunks +15 lines, -15 lines 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M mojo/cc/output_surface_mojo.h View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/cc/output_surface_mojo.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M mojo/runner/android/main.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
Created Revert of Mandoline UI Process: Update namespaces and file names
5 years, 3 months ago (2015-09-17 02:46:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1351013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1351013002/1
5 years, 3 months ago (2015-09-17 02:47:08 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 02:48:56 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 02:49:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35b19f7d5d7b7b68878d6c766e93e148f8b06998
Cr-Commit-Position: refs/heads/master@{#349332}

Powered by Google App Engine
This is Rietveld 408576698