Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(880)

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_request.cc
diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc
index a99074f2ce3aeb56440b44cc0e9530f0f0c1db39..b38889847121b6d9bf86418d4ab80efae1d71021 100644
--- a/content/browser/frame_host/navigation_request.cc
+++ b/content/browser/frame_host/navigation_request.cc
@@ -204,6 +204,8 @@ void NavigationRequest::CreateNavigationHandle(NavigatorDelegate* delegate) {
void NavigationRequest::TransferNavigationHandleOwnership(
RenderFrameHostImpl* render_frame_host) {
render_frame_host->SetNavigationHandle(navigation_handle_.Pass());
+ render_frame_host->navigation_handle()->ReadyToCommitNavigation(
nasko 2015/09/18 16:42:16 Why here instead of right before CommitNavigation
clamy 2015/09/18 20:37:33 Because we don't have a renderer prior to the call
+ render_frame_host);
}
void NavigationRequest::OnRequestRedirected(

Powered by Google App Engine
This is Rietveld 408576698