Remove WebContentsObserver::DidCommitNavigation

content/browser/frame_host/navigation_request.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/navigation_request.h"
 
 #include "content/browser/frame_host/frame_tree.h"
 #include "content/browser/frame_host/frame_tree_node.h"
 #include "content/browser/frame_host/navigation_controller_impl.h"
 #include "content/browser/frame_host/navigation_handle_impl.h"
@@ skipping 186 matching lines @@
 }
 
 void NavigationRequest::CreateNavigationHandle(NavigatorDelegate* delegate) {
   navigation_handle_ = NavigationHandleImpl::Create(
       common_params_.url, frame_tree_node_->IsMainFrame(), delegate);
 }
 
 void NavigationRequest::TransferNavigationHandleOwnership(
     RenderFrameHostImpl* render_frame_host) {
   render_frame_host->SetNavigationHandle(navigation_handle_.Pass());
+  render_frame_host->navigation_handle()->ReadyToCommitNavigation(

[nasko, 2015/09/18 16:42:16]

Why here instead of right before CommitNavigation call in OnResponseStarted? It
isn't immediately clear why this is correct.

[clamy, 2015/09/18 20:37:33]

Because we don't have a renderer prior to the call to CommitNavigation. And
after the call this request is destroyed. The handle is transfered before any
IPC is sent.

+      render_frame_host);
 }
 
 void NavigationRequest::OnRequestRedirected(
     const net::RedirectInfo& redirect_info,
     const scoped_refptr<ResourceResponse>& response) {
   // TODO(davidben): Track other changes from redirects. These are important
   // for, e.g., reloads.
   common_params_.url = redirect_info.new_url;
 
   // TODO(davidben): This where prerender and navigation_interceptor should be
@@ skipping 20 matching lines @@
   frame_tree_node_->navigator()->FailedNavigation(
       frame_tree_node_, has_stale_copy_in_cache, net_error);
 }
 
 void NavigationRequest::OnRequestStarted(base::TimeTicks timestamp) {
   frame_tree_node_->navigator()->LogResourceRequestTime(timestamp,
                                                         common_params_.url);
 }
 
 }  // namespace content