Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/frame_host/navigator_delegate.h

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/frame_host/navigation_request.cc ('K') | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | content/browser/frame_host/navigator_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigator_delegate.h
diff --git a/content/browser/frame_host/navigator_delegate.h b/content/browser/frame_host/navigator_delegate.h
index 14ab69b5733310c42105a3f534ea00dba2bf7680..84f9da32ad825db8c911d6feff3ab3b3abd1defb 100644
--- a/content/browser/frame_host/navigator_delegate.h
+++ b/content/browser/frame_host/navigator_delegate.h
@@ -37,9 +37,6 @@ class CONTENT_EXPORT NavigatorDelegate {
// Called when the navigation is about to be committed in a renderer.
virtual void ReadyToCommitNavigation(NavigationHandle* navigation_handle) {}
- // Called when a navigation committed.
- virtual void DidCommitNavigation(NavigationHandle* navigation_handle) {}
-
// Called when a document load resulting from the navigation stopped. Note
nasko 2015/09/18 16:42:16 Let's update the comment. We don't track document
clamy 2015/09/18 20:37:33 Done.
// that |navigation_handle| will be destroyed at the end of this call.
virtual void DidFinishNavigation(NavigationHandle* navigation_handle) {}
« content/browser/frame_host/navigation_request.cc ('K') | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/frame_host/navigator_impl.cc » ('j') | content/browser/frame_host/navigator_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698