content/browser/web_contents/web_contents_impl.cc - Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 78689f2f694ead9c86e9618ce32b762feadb76b4..9f06d0fe94926a9cb514fd337011781d4f83b9d4 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -2802,11 +2802,6 @@ void WebContentsImpl::ReadyToCommitNavigation(

ReadyToCommitNavigation(navigation_handle));

}

-void WebContentsImpl::DidCommitNavigation(NavigationHandle* navigation_handle) {

- FOR_EACH_OBSERVER(WebContentsObserver, observers_,

- DidCommitNavigation(navigation_handle));

void WebContentsImpl::DidFinishNavigation(NavigationHandle* navigation_handle) {

FOR_EACH_OBSERVER(WebContentsObserver, observers_,

DidFinishNavigation(navigation_handle));