Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 2784 matching lines...) Expand 10 before | Expand all | Expand 10 after
2795 FOR_EACH_OBSERVER(WebContentsObserver, observers_, 2795 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2796 DidRedirectNavigation(navigation_handle)); 2796 DidRedirectNavigation(navigation_handle));
2797 } 2797 }
2798 2798
2799 void WebContentsImpl::ReadyToCommitNavigation( 2799 void WebContentsImpl::ReadyToCommitNavigation(
2800 NavigationHandle* navigation_handle) { 2800 NavigationHandle* navigation_handle) {
2801 FOR_EACH_OBSERVER(WebContentsObserver, observers_, 2801 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2802 ReadyToCommitNavigation(navigation_handle)); 2802 ReadyToCommitNavigation(navigation_handle));
2803 } 2803 }
2804 2804
2805 void WebContentsImpl::DidCommitNavigation(NavigationHandle* navigation_handle) {
2806 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2807 DidCommitNavigation(navigation_handle));
2808 }
2809
2810 void WebContentsImpl::DidFinishNavigation(NavigationHandle* navigation_handle) { 2805 void WebContentsImpl::DidFinishNavigation(NavigationHandle* navigation_handle) {
2811 FOR_EACH_OBSERVER(WebContentsObserver, observers_, 2806 FOR_EACH_OBSERVER(WebContentsObserver, observers_,
2812 DidFinishNavigation(navigation_handle)); 2807 DidFinishNavigation(navigation_handle));
2813 } 2808 }
2814 2809
2815 void WebContentsImpl::DidStartProvisionalLoad( 2810 void WebContentsImpl::DidStartProvisionalLoad(
2816 RenderFrameHostImpl* render_frame_host, 2811 RenderFrameHostImpl* render_frame_host,
2817 const GURL& validated_url, 2812 const GURL& validated_url,
2818 bool is_error_page, 2813 bool is_error_page,
2819 bool is_iframe_srcdoc) { 2814 bool is_iframe_srcdoc) {
(...skipping 1821 matching lines...) Expand 10 before | Expand all | Expand 10 after
4641 return NULL; 4636 return NULL;
4642 } 4637 }
4643 4638
4644 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) { 4639 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
4645 force_disable_overscroll_content_ = force_disable; 4640 force_disable_overscroll_content_ = force_disable;
4646 if (view_) 4641 if (view_)
4647 view_->SetOverscrollControllerEnabled(CanOverscrollContent()); 4642 view_->SetOverscrollControllerEnabled(CanOverscrollContent());
4648 } 4643 }
4649 4644
4650 } // namespace content 4645 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/public/browser/navigation_handle.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698