Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: content/public/browser/navigation_handle.h

Issue 1350673003: Remove WebContentsObserver::DidCommitNavigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/navigation_handle.h
diff --git a/content/public/browser/navigation_handle.h b/content/public/browser/navigation_handle.h
index c60babaa9939a4f0861eb1c0f2b7d9d7597c755f..18183736a1a78a230f69853a7360576c8f63402e 100644
--- a/content/public/browser/navigation_handle.h
+++ b/content/public/browser/navigation_handle.h
@@ -11,6 +11,7 @@
class GURL;
namespace content {
+class RenderFrameHost;
// A NavigationHandle tracks information related to a single navigation.
class CONTENT_EXPORT NavigationHandle {
@@ -28,16 +29,23 @@ class CONTENT_EXPORT NavigationHandle {
// Whether the navigation is taking place in the main frame or in a subframe.
virtual bool IsInMainFrame() const = 0;
+ // Returns the RenderFrameHost this navigation is taking place in. This can
+ // only be accessed after the navigation is ready to commit.
+ virtual RenderFrameHost* GetRenderFrameHost() = 0;
+
// Whether the navigation happened in the same page. This is only known
// after the navigation has committed. It is an error to call this method
// before the navigation has committed.
virtual bool IsSamePage() = 0;
- // Whether the navigation has successfully committed a document.
- virtual bool HasCommittedDocument() const = 0;
+ // Whether the navigation has committed. This returns true for either
+ // successful commits or error pages that replace the previous page
+ // (distinguished by |IsErrorPage|), and false for errors that leave the user
+ // on the previous page.
+ virtual bool HasCommitted() = 0;
- // Whether an error page has committed for the navigation.
- virtual bool HasCommittedErrorPage() const = 0;
+ // Whether the navigation resulted in an error page.
+ virtual bool IsErrorPage() = 0;
};
} // namespace content
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698