Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/sync_socket_win.cc

Issue 1350493002: Check for CloseHandle failures even when not debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DCHECK to CHECK Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« base/memory/shared_memory_win.cc ('K') | « base/sync_socket_unittest.cc ('k') | base/threading/platform_thread_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/sync_socket_win.cc
diff --git a/base/sync_socket_win.cc b/base/sync_socket_win.cc
index e5088162433f2f402a8809c1342142c028e07341..fb722919f6c45239810eb45c01bdfe21d0d06cdf 100644
--- a/base/sync_socket_win.cc
+++ b/base/sync_socket_win.cc
@@ -235,7 +235,8 @@ bool SyncSocket::Close() {
if (handle_ == kInvalidHandle)
return true;
- const BOOL result = CloseHandle(handle_);
+ const BOOL result = ::CloseHandle(handle_);
+ CHECK(result);
Lei Zhang 2015/09/22 08:03:30 Also PCHECK()
handle_ = kInvalidHandle;
return result == TRUE;
}
« base/memory/shared_memory_win.cc ('K') | « base/sync_socket_unittest.cc ('k') | base/threading/platform_thread_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698