base/memory/shared_memory_win.cc - Issue 1350493002: Check for CloseHandle failures even when not debugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/memory/shared_memory_win.cc

Issue 1350493002: Check for CloseHandle failures even when not debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: DCHECK to CHECK Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/memory/shared_memory_win.cc

diff --git a/base/memory/shared_memory_win.cc b/base/memory/shared_memory_win.cc

index 5f706fe648598642584903f39a5aa40786acc88d..285d9ac3239b35bb663bbe6588e543f86026f152 100644

--- a/base/memory/shared_memory_win.cc

+++ b/base/memory/shared_memory_win.cc

@@ -85,7 +85,8 @@ SharedMemoryHandle SharedMemory::NULLHandle() {

// static

void SharedMemory::CloseHandle(const SharedMemoryHandle& handle) {

DCHECK(handle != NULL);

- ::CloseHandle(handle);

+ const BOOL result = ::CloseHandle(handle);

+ CHECK(result);

Lei Zhang 2015/09/22 08:03:30 I know this will probably reland as soon as I fix

}

// static

« no previous file with comments | « base/files/file_util_win.cc ('k') | base/process/kill_win.cc » ('j') | base/sync_socket_win.cc » ('J')