Check for CloseHandle failures even when not debugging

base/sync_socket_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sync_socket.h"
 
 #include "base/logging.h"
 #include "base/threading/thread_restrictions.h"
 #include "base/win/scoped_handle.h"
 
@@ skipping 217 matching lines @@
     DPLOG(ERROR) << "Cannot duplicate socket handle for peer process.";
     return false;
   }
   return true;
 }
 
 bool SyncSocket::Close() {
   if (handle_ == kInvalidHandle)
     return true;
 
-  const BOOL result = CloseHandle(handle_);
+  const BOOL result = ::CloseHandle(handle_);
+  CHECK(result);

[Lei Zhang, 2015/09/22 08:03:30]

Also PCHECK()

   handle_ = kInvalidHandle;
   return result == TRUE;
 }
 
 size_t SyncSocket::Send(const void* buffer, size_t length) {
   ThreadRestrictions::AssertIOAllowed();
   DCHECK_GT(length, 0u);
   DCHECK_LE(length, kMaxMessageLength);
   DCHECK_NE(handle_, kInvalidHandle);
   size_t count = 0;
@@ skipping 84 matching lines @@
       static_cast<DWORD>(timeout.InMilliseconds()));
 }
 
 // static
 bool CancelableSyncSocket::CreatePair(CancelableSyncSocket* socket_a,
                                       CancelableSyncSocket* socket_b) {
   return CreatePairImpl(&socket_a->handle_, &socket_b->handle_, true);
 }
 
 }  // namespace base