Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3063)

Unified Diff: base/process/kill_win.cc

Issue 1350493002: Check for CloseHandle failures even when not debugging (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DCHECK to CHECK Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/process/kill_win.cc
diff --git a/base/process/kill_win.cc b/base/process/kill_win.cc
index 0da3a26ae4f78e9af924609904e81db7872958e2..b35dd6321696e982580ba2704d78b4811e524ff2 100644
--- a/base/process/kill_win.cc
+++ b/base/process/kill_win.cc
@@ -159,11 +159,8 @@ bool WaitForProcessesToExit(const FilePath::StringType& executable_name,
DWORD remaining_wait = static_cast<DWORD>(std::max(
static_cast<int64>(0),
wait.InMilliseconds() - (GetTickCount() - start_time)));
- HANDLE process = OpenProcess(SYNCHRONIZE,
- FALSE,
- entry->th32ProcessID);
- DWORD wait_result = WaitForSingleObject(process, remaining_wait);
- CloseHandle(process);
+ Process process(Process::OpenWithAccess(entry->th32ProcessID, SYNCHRONIZE));
+ DWORD wait_result = WaitForSingleObject(process.Handle(), remaining_wait);
result &= (wait_result == WAIT_OBJECT_0);
}

Powered by Google App Engine
This is Rietveld 408576698