Check for CloseHandle failures even when not debugging

base/sync_socket_unittest.cc

Index: base/sync_socket_unittest.cc
diff --git a/base/sync_socket_unittest.cc b/base/sync_socket_unittest.cc
index ff9b8bc8c2f0c7a932d034da2080335e19a7481c..9c8eb0bf737880bed1ea409ac899c74692d79ff6 100644
--- a/base/sync_socket_unittest.cc
+++ b/base/sync_socket_unittest.cc
@@ -94,9 +94,7 @@ void ClonedSendReceivePeek() {
   SocketType socket_a, socket_b;
   ASSERT_TRUE(SocketType::CreatePair(&socket_a, &socket_b));
 
-  // Create new SyncSockets from the paired handles.
-  SocketType socket_c(socket_a.handle()), socket_d(socket_b.handle());
-  SendReceivePeek(&socket_c, &socket_d);
+  SendReceivePeek(&socket_a, &socket_b);

[brucedawson, 2015/09/16 00:30:52]

This fixes 520305. Duplicating handles like that within a process is not valid.
I'm not sure what the point of the duplication was.

[DaleCurtis, 2015/09/16 00:43:19]

This is just the same as the NormalSendReceivePeek() above then unfortunately --
If we can't fix this, we'll have to just delete this test.

[brucedawson, 2015/09/16 18:29:00]

Tests deleted.

 }
 
 }  // namespace