Check for CloseHandle failures even when not debugging

base/sync_socket_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/basictypes.h"
 // TODO(ellyjones): Remove once http://crbug.com/523296 is fixed.
 #if defined(OS_IOS) && !TARGET_IPHONE_SIMULATOR
 #include "base/ios/ios_util.h"
 #endif
 #include "base/sync_socket.h"
@@ skipping 76 matching lines @@
   SocketType socket_a, socket_b;
   ASSERT_TRUE(SocketType::CreatePair(&socket_a, &socket_b));
   SendReceivePeek(&socket_a, &socket_b);
 }
 
 template <class SocketType>
 void ClonedSendReceivePeek() {
   SocketType socket_a, socket_b;
   ASSERT_TRUE(SocketType::CreatePair(&socket_a, &socket_b));
 
-  // Create new SyncSockets from the paired handles.
-  SocketType socket_c(socket_a.handle()), socket_d(socket_b.handle());
-  SendReceivePeek(&socket_c, &socket_d);
+  SendReceivePeek(&socket_a, &socket_b);

[brucedawson, 2015/09/16 00:30:52]

This fixes 520305. Duplicating handles like that within a process is not valid.
I'm not sure what the point of the duplication was.

[DaleCurtis, 2015/09/16 00:43:19]

This is just the same as the NormalSendReceivePeek() above then unfortunately --
If we can't fix this, we'll have to just delete this test.

[brucedawson, 2015/09/16 18:29:00]

Tests deleted.

 }
 
 }  // namespace
 
 TEST(SyncSocket, NormalSendReceivePeek) {
   NormalSendReceivePeek<base::SyncSocket>();
 }
 
 TEST(SyncSocket, ClonedSendReceivePeek) {
   ClonedSendReceivePeek<base::SyncSocket>();
@@ skipping 21 matching lines @@
   ASSERT_TRUE(socket_b.Shutdown());
   thread.Stop();
 
   // Ensure the receive didn't just timeout.
   ASSERT_LT((base::TimeTicks::Now() - start).InMilliseconds(),
             kReceiveTimeoutInMilliseconds);
 
   ASSERT_TRUE(socket_a.Close());
   ASSERT_TRUE(socket_b.Close());
 }