Check for CloseHandle failures even when not debugging

base/sync_socket_win.cc

Index: base/sync_socket_win.cc
diff --git a/base/sync_socket_win.cc b/base/sync_socket_win.cc
index e5088162433f2f402a8809c1342142c028e07341..b2946c18e24afd32d28cde1d6708ae3313a6ac7f 100644
--- a/base/sync_socket_win.cc
+++ b/base/sync_socket_win.cc
@@ -235,7 +235,8 @@ bool SyncSocket::Close() {
   if (handle_ == kInvalidHandle)
     return true;
 
-  const BOOL result = CloseHandle(handle_);
+  const BOOL result = ::CloseHandle(handle_);
+  DCHECK(result);

[brucedawson, 2015/09/16 00:30:52]

This detected 520305.

[rvargas (doing something else), 2015/09/16 02:09:12]

Use CHECK

[brucedawson, 2015/09/16 18:29:00]

Done.

   handle_ = kInvalidHandle;
   return result == TRUE;
 }