mandoline: Make sure omnibox gets updated when navigating back/forwards.

mandoline: Make sure omnibox gets updated when navigating back/forwards.

. Change WebViewClient::TopLevelNavigate() to TopLevelNavigateRequest() to
  better reflect that the client can intercept the request and do things
  other than doing a navigation.
. Introduce WebViewClient::TopLevelNavigationStarted(url) to notify the
  client when navigation starts. Update the omnibox from this callback.

BUG=526268
Committed: https://crrev.com/367c9c47fd5dac05688ac2fe864db26d780e7c33
Cr-Commit-Position: refs/heads/master@{#351073}

[sadrul, 2015-09-19 03:31:39]

sadrul@chromium.org changed reviewers:
+ erg@chromium.org, sky@chromium.org

[sky, 2015-09-21 14:59:47]

https://codereview.chromium.org/1350223005/diff/1/components/web_view/web_vie...
File components/web_view/web_view_impl.cc (right):

https://codereview.chromium.org/1350223005/diff/1/components/web_view/web_vie...
components/web_view/web_view_impl.cc:207:
client_->TopLevelNavigationStarted(request->url);
Are you sure you don't want to notify from OnLoad?

[sadrul, 2015-09-23 04:32:14]

https://codereview.chromium.org/1350223005/diff/1/components/web_view/web_vie...
File components/web_view/web_view_impl.cc (right):

https://codereview.chromium.org/1350223005/diff/1/components/web_view/web_vie...
components/web_view/web_view_impl.cc:207:
client_->TopLevelNavigationStarted(request->url);
On 2015/09/21 14:59:46, sky wrote:
> Are you sure you don't want to notify from OnLoad?

That looks like a better place. Made this change. Thanks

[sky, 2015-09-23 15:31:45]

https://codereview.chromium.org/1350223005/diff/20001/components/web_view/pen...
File components/web_view/pending_web_view_load.h (right):

https://codereview.chromium.org/1350223005/diff/20001/components/web_view/pen...
components/web_view/pending_web_view_load.h:42: std::string pending_url_;
Can we make this a GURL?

[sadrul, 2015-09-27 05:29:39]

https://codereview.chromium.org/1350223005/diff/20001/components/web_view/pen...
File components/web_view/pending_web_view_load.h (right):

https://codereview.chromium.org/1350223005/diff/20001/components/web_view/pen...
components/web_view/pending_web_view_load.h:42: std::string pending_url_;
On 2015/09/23 15:31:44, sky wrote:
> Can we make this a GURL?

Done. (the new TopLevelNavigationStarted() interface is still using strings
since it's in a mojom. I briefly considered using a URLRequest there, but
decided against it).

[sky, 2015-09-28 15:09:03]

LGTM

[sadrul, 2015-09-28 15:31:29]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2015-09-28 15:31:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1350223005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1350223005/60001

[commit-bot: I haz the power, 2015-09-28 15:47:16]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-28 15:48:02]

Patchset 4 (id:??) landed as
https://crrev.com/367c9c47fd5dac05688ac2fe864db26d780e7c33
Cr-Commit-Position: refs/heads/master@{#351073}