components/web_view/public/interfaces/web_view.mojom - Issue 1350223005: mandoline: Make sure omnibox gets updated when navigating back/forwards.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_view/public/interfaces/web_view.mojom

Issue 1350223005: mandoline: Make sure omnibox gets updated when navigating back/forwards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tot.merge Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_view/pending_web_view_load.cc ('k') | components/web_view/test_runner/test_runner_application_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_view/public/interfaces/web_view.mojom

diff --git a/components/web_view/public/interfaces/web_view.mojom b/components/web_view/public/interfaces/web_view.mojom

index d5bab2b4698cd83f35d9a5184d787caebdff923f..1385b8de2d50b4a047e1a6cc2a102108516132e8 100644

--- a/components/web_view/public/interfaces/web_view.mojom

+++ b/components/web_view/public/interfaces/web_view.mojom

@@ -14,7 +14,12 @@ enum ButtonState {

interface WebViewClient {

// Page-generated request for a top level frame navigation.

- TopLevelNavigate(mojo.URLRequest request);

+ TopLevelNavigateRequest(mojo.URLRequest request);

+ // Notification that the navigation has started. This can be useful for

+ // navigations triggered from sources other than the page itself (e.g.

+ // back/forward history navigation).

+ TopLevelNavigationStarted(string url);

// Loading and progress notifications.

LoadingStateChanged(bool is_loading, double progress);

« no previous file with comments | « components/web_view/pending_web_view_load.cc ('k') | components/web_view/test_runner/test_runner_application_delegate.h » ('j') | no next file with comments »