mandoline/ui/desktop_ui/browser_window.h - Issue 1350223005: mandoline: Make sure omnibox gets updated when navigating back/forwards.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mandoline/ui/desktop_ui/browser_window.h

Issue 1350223005: mandoline: Make sure omnibox gets updated when navigating back/forwards. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: tot.merge Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: mandoline/ui/desktop_ui/browser_window.h

diff --git a/mandoline/ui/desktop_ui/browser_window.h b/mandoline/ui/desktop_ui/browser_window.h

index c420a639297e2f80daf6d2be7d40fb354958914b..368a57214eb13ea9dfea08ad4e7abd31dc0e9cc8 100644

--- a/mandoline/ui/desktop_ui/browser_window.h

+++ b/mandoline/ui/desktop_ui/browser_window.h

@@ -61,7 +61,8 @@ class BrowserWindow : public mus::ViewTreeDelegate,

void OnAccelerator(uint32_t id, mojo::EventPtr event) override;

// Overridden from web_view::mojom::WebViewClient:

- void TopLevelNavigate(mojo::URLRequestPtr request) override;

+ void TopLevelNavigateRequest(mojo::URLRequestPtr request) override;

+ void TopLevelNavigationStarted(const mojo::String& url) override;

void LoadingStateChanged(bool is_loading, double progress) override;

void BackForwardChanged(web_view::mojom::ButtonState back_button,

web_view::mojom::ButtonState forward_button) override;

« no previous file with comments | « components/web_view/web_view_impl.cc ('k') | mandoline/ui/desktop_ui/browser_window.cc » ('j') | no next file with comments »