Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 1349833005: Improve use of CfgLocalAllocator and introduce containers that use it. (Closed)

Created:
5 years, 3 months ago by ascull
Modified:
5 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Improve use of CfgLocalAllocator and introduce containers that use it. This doesn't make a big difference but does reduce the proportion of time spent in malloc and free. BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=00741a005cf242d2e9108f7cc7c454246e13741c

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -109 lines) Patch
M Makefile.standalone View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/IceCfg.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceCfg.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceCfgNode.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M src/IceDefs.h View 2 chunks +8 lines, -5 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M src/IceInst.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/IceLiveness.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/IceLoopAnalyzer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/IceOperand.h View 5 chunks +6 lines, -6 lines 0 comments Download
M src/IceRegAlloc.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/IceRegAlloc.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceSwitchLowering.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/IceTargetLoweringX86BaseImpl.h View 2 chunks +69 lines, -68 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ascull
This is a redo of issue 1341153002 without the extra junk (and with it not ...
5 years, 3 months ago (2015-09-16 22:02:11 UTC) #1
ascull
I wish it would tell me when I forget to put the reviewers. This is ...
5 years, 3 months ago (2015-09-17 01:01:28 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1349833005/diff/1/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1349833005/diff/1/Makefile.standalone#newcode124 Makefile.standalone:124: # TODO(ascull): this has an as yet undiagnosed ...
5 years, 3 months ago (2015-09-17 01:56:24 UTC) #4
ascull
https://codereview.chromium.org/1349833005/diff/1/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1349833005/diff/1/Makefile.standalone#newcode124 Makefile.standalone:124: # TODO(ascull): this has an as yet undiagnosed uninitialized ...
5 years, 3 months ago (2015-09-17 02:04:02 UTC) #5
ascull
5 years, 3 months ago (2015-09-17 02:04:14 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
00741a005cf242d2e9108f7cc7c454246e13741c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698