src/IceGlobalContext.cpp - Issue 1349833005: Improve use of CfgLocalAllocator and introduce containers that use it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceGlobalContext.cpp

Issue 1349833005: Improve use of CfgLocalAllocator and introduce containers that use it. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: src/IceGlobalContext.cpp

diff --git a/src/IceGlobalContext.cpp b/src/IceGlobalContext.cpp

index 7b7183d5540852496e2ff9a1b0b256a9635aa61f..c7497da83df5a8978fdcdbfdd1fba6045acb1c70 100644

--- a/src/IceGlobalContext.cpp

+++ b/src/IceGlobalContext.cpp

@@ -722,10 +722,8 @@ GlobalContext::~GlobalContext() {

llvm::DeleteContainerPointers(AllThreadContexts);

LockedPtr<DestructorArray> Dtors = getDestructors();

// Destructors are invoked in the opposite object construction order.

- for (auto DtorIter = Dtors->crbegin(); DtorIter != Dtors->crend();

- ++DtorIter) {

- (*DtorIter)();

- }

+ for (const auto &Dtor : reverse_range(*Dtors))

+ Dtor();

}

// TODO(stichnot): Consider adding thread-local caches of constant pool entries

« no previous file with comments | « src/IceDefs.h ('k') | src/IceInst.h » ('j') | no next file with comments »