Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: net/tools/flip_server/streamer_interface.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/flip_server/streamer_interface.h
diff --git a/net/tools/flip_server/streamer_interface.h b/net/tools/flip_server/streamer_interface.h
index 69891f3a02deb8b8c41477165886b352fbd5087d..ef666695ec3135c8a4f1d517cf4f6f423cda878f 100644
--- a/net/tools/flip_server/streamer_interface.h
+++ b/net/tools/flip_server/streamer_interface.h
@@ -57,7 +57,7 @@ class StreamerSM : public BalsaVisitorInterface, public SMInterface {
const std::string& filename) override {}
void SendEOF(uint32 stream_id) override {}
void SendErrorNotFound(uint32 stream_id) override {}
- virtual void SendOKResponse(uint32 stream_id, std::string output) {}
+ virtual void SendOKResponse(uint32 stream_id, const std::string& output) {}
size_t SendSynStream(uint32 stream_id, const BalsaHeaders& headers) override;
size_t SendSynReply(uint32 stream_id, const BalsaHeaders& headers) override;
void SendDataFrame(uint32 stream_id,
@@ -67,7 +67,7 @@ class StreamerSM : public BalsaVisitorInterface, public SMInterface {
bool compress) override {}
void set_is_request() override;
static std::string forward_ip_header() { return forward_ip_header_; }
- static void set_forward_ip_header(std::string value) {
+ static void set_forward_ip_header(const std::string& value) {
forward_ip_header_ = value;
}

Powered by Google App Engine
This is Rietveld 408576698