net/tools/quic/quic_server_session.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_server_session.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_server_session.h

diff --git a/net/tools/quic/quic_server_session.h b/net/tools/quic/quic_server_session.h

index 20471de6b62c04641dbc5929380e65e0e1369bc7..14d7b29f8a7c97ef4041d1a62b38257663052ae3 100644

--- a/net/tools/quic/quic_server_session.h

+++ b/net/tools/quic/quic_server_session.h

@@ -91,7 +91,7 @@ class QuicServerSession : public QuicSpdySession {

return GetCryptoStream()->peer_supports_stateless_rejects();

}

- void set_serving_region(std::string serving_region) {

+ void set_serving_region(const std::string& serving_region) {

serving_region_ = serving_region;

}

« no previous file with comments | « net/tools/flip_server/streamer_interface.h ('k') | net/tools/quic/test_tools/quic_test_client.h » ('j') | url/gurl.h » ('J')