Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: net/tools/flip_server/spdy_util.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/flip_server/spdy_util.cc
diff --git a/net/tools/flip_server/spdy_util.cc b/net/tools/flip_server/spdy_util.cc
index a8cbd683dcdc577369c347fd7529abfeaf6f112d..34b6072cfa85acb82be0e9d28d7ab4b9c5076312 100644
--- a/net/tools/flip_server/spdy_util.cc
+++ b/net/tools/flip_server/spdy_util.cc
@@ -13,7 +13,9 @@ namespace net {
bool g_need_to_encode_url = false;
// Encode the URL.
-std::string EncodeURL(std::string uri, std::string host, std::string method) {
+std::string EncodeURL(const std::string& uri,
+ const std::string& host,
+ const std::string& method) {
if (!g_need_to_encode_url) {
// TODO(mbelshe): if uri is fully qualified, need to strip protocol/host.
return std::string(method + "_" + uri);

Powered by Google App Engine
This is Rietveld 408576698