Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Unified Diff: net/filter/sdch_filter_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/filter/sdch_filter_unittest.cc
diff --git a/net/filter/sdch_filter_unittest.cc b/net/filter/sdch_filter_unittest.cc
index a83e63ff4c9b0971f97428d432cb2e3a1fcc1d77..35276cb764a5b22e8106de00b4ea3fde0be675b3 100644
--- a/net/filter/sdch_filter_unittest.cc
+++ b/net/filter/sdch_filter_unittest.cc
@@ -85,7 +85,7 @@ class SdchFilterTest : public testing::Test {
sdch_manager_->GetDictionarySet(url).Pass());
}
- std::string NewSdchCompressedData(const std::string dictionary) {
+ std::string NewSdchCompressedData(const std::string& dictionary) {
std::string client_hash;
std::string server_hash;
SdchManager::GenerateHash(dictionary, &client_hash, &server_hash);
« no previous file with comments | « net/dns/serial_worker_unittest.cc ('k') | net/http/http_cache_unittest.cc » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698