Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Unified Diff: net/http/http_cache_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_cache_unittest.cc
diff --git a/net/http/http_cache_unittest.cc b/net/http/http_cache_unittest.cc
index 12a849c027ce663887f893036a4bc519b01f337b..5992b3ba075964224862e36a248e26a76f0ed6ef 100644
--- a/net/http/http_cache_unittest.cc
+++ b/net/http/http_cache_unittest.cc
@@ -463,7 +463,7 @@ const char kFullRangeData[] =
// Verifies the response headers (|response|) match a partial content
// response for the range starting at |start| and ending at |end|.
-void Verify206Response(std::string response, int start, int end) {
+void Verify206Response(const std::string& response, int start, int end) {
std::string raw_headers(
HttpUtil::AssembleRawHeaders(response.data(), response.size()));
scoped_refptr<HttpResponseHeaders> headers(

Powered by Google App Engine
This is Rietveld 408576698