Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: net/dns/serial_worker_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/dns/serial_worker_unittest.cc
diff --git a/net/dns/serial_worker_unittest.cc b/net/dns/serial_worker_unittest.cc
index da8783064294f5e31ca405369e2c726aa2069801..7a1b56f7d858ab210a1126131d4274d4e3ca96bd 100644
--- a/net/dns/serial_worker_unittest.cc
+++ b/net/dns/serial_worker_unittest.cc
@@ -63,18 +63,18 @@ class SerialWorkerTest : public testing::Test {
}
protected:
- void BreakCallback(std::string breakpoint) {
+ void BreakCallback(const std::string& breakpoint) {
breakpoint_ = breakpoint;
base::MessageLoop::current()->QuitNow();
}
- void BreakNow(std::string b) {
+ void BreakNow(const std::string& b) {
message_loop_->task_runner()->PostTask(
FROM_HERE, base::Bind(&SerialWorkerTest::BreakCallback,
base::Unretained(this), b));
}
- void RunUntilBreak(std::string b) {
+ void RunUntilBreak(const std::string& b) {
message_loop_->Run();
ASSERT_EQ(breakpoint_, b);
}

Powered by Google App Engine
This is Rietveld 408576698