net/dns/mock_mdns_socket_factory.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/mock_mdns_socket_factory.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/mock_mdns_socket_factory.cc

diff --git a/net/dns/mock_mdns_socket_factory.cc b/net/dns/mock_mdns_socket_factory.cc

index b241da64da5c746723475af5a473d4f1f20beac9..88c0dcfa22306400aa908952c7632edd56f04c0e 100644

--- a/net/dns/mock_mdns_socket_factory.cc

+++ b/net/dns/mock_mdns_socket_factory.cc

@@ -36,7 +36,7 @@ int MockMDnsDatagramServerSocket::GetLocalAddress(IPEndPoint* address) const {

}

void MockMDnsDatagramServerSocket::SetResponsePacket(

- std::string response_packet) {

+ const std::string& response_packet) {

response_packet_ = response_packet;

}

« no previous file with comments | « net/dns/mock_mdns_socket_factory.h ('k') | net/dns/serial_worker_unittest.cc » ('j') | url/gurl.h » ('J')