net/dns/mock_mdns_socket_factory.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/mock_mdns_socket_factory.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/dns/mock_mdns_socket_factory.h

diff --git a/net/dns/mock_mdns_socket_factory.h b/net/dns/mock_mdns_socket_factory.h

index c1536bc18c5561bbcee32b76c30126719bbeed01..34f482072c5addfb1e7e8998c24b35af1349d5ad 100644

--- a/net/dns/mock_mdns_socket_factory.h

+++ b/net/dns/mock_mdns_socket_factory.h

@@ -58,7 +58,7 @@ class MockMDnsDatagramServerSocket : public DatagramServerSocket {

MOCK_METHOD0(DetachFromThread, void());

- void SetResponsePacket(std::string response_packet);

+ void SetResponsePacket(const std::string& response_packet);

int HandleRecvNow(IOBuffer* buffer, int size, IPEndPoint* address,

const CompletionCallback& callback);

« no previous file with comments | « net/dns/mdns_client_unittest.cc ('k') | net/dns/mock_mdns_socket_factory.cc » ('j') | url/gurl.h » ('J')