Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: ios/chrome/common/string_util.mm

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/common/string_util.mm
diff --git a/ios/chrome/common/string_util.mm b/ios/chrome/common/string_util.mm
index d8fca0e71a6266a9389f853dc85c7f97beb9509e..395f66035276d4a244542b05aaa3a9063bc4469f 100644
--- a/ios/chrome/common/string_util.mm
+++ b/ios/chrome/common/string_util.mm
@@ -116,7 +116,8 @@ NSString* CleanNSStringForDisplay(NSString* dirty, BOOL removeGraphicChars) {
return cleanString;
}
-std::string CleanStringForDisplay(std::string dirty, BOOL removeGraphicChars) {
+std::string CleanStringForDisplay(const std::string& dirty,
+ BOOL removeGraphicChars) {
return base::SysNSStringToUTF8(CleanNSStringForDisplay(
base::SysUTF8ToNSString(dirty), removeGraphicChars));
}
« no previous file with comments | « ios/chrome/common/string_util.h ('k') | ios/crnet/crnet_environment.h » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698