ios/crnet/crnet_environment.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/crnet/crnet_environment.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/crnet/crnet_environment.h

diff --git a/ios/crnet/crnet_environment.h b/ios/crnet/crnet_environment.h

index b007fbbde86f27a94c8924d45549bb75b852f86b..71afb17aa449b79a0fe0f68535b6a9c811884b92 100644

--- a/ios/crnet/crnet_environment.h

+++ b/ios/crnet/crnet_environment.h

@@ -36,7 +36,7 @@ class CrNetEnvironment {

static void Initialize();

// |user_agent_product_name| will be used to generate the user-agent.

- CrNetEnvironment(std::string user_agent_product_name);

+ CrNetEnvironment(const std::string& user_agent_product_name);

~CrNetEnvironment();

// Installs this CrNet environment so requests are intercepted.

« no previous file with comments | « ios/chrome/common/string_util.mm ('k') | ios/crnet/crnet_environment.mm » ('j') | url/gurl.h » ('J')