ios/chrome/common/string_util.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/common/string_util.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/common/string_util.h

diff --git a/ios/chrome/common/string_util.h b/ios/chrome/common/string_util.h

index b0813212ca5abf64a46777b4760a00e683e6b1a8..b977c4b05a82824d95faf9d05e320327926eb197 100644

--- a/ios/chrome/common/string_util.h

+++ b/ios/chrome/common/string_util.h

@@ -27,7 +27,8 @@ NSCharacterSet* GraphicCharactersSet();

NSString* CleanNSStringForDisplay(NSString* dirty, BOOL removeGraphicChars);

// Cleans a std::string identically to CleanNSStringForDisplay()

-std::string CleanStringForDisplay(std::string dirty, BOOL removeGraphicChars);

+std::string CleanStringForDisplay(const std::string& dirty,

+ BOOL removeGraphicChars);

// Find the longest leading substring of |string| that, when rendered with

« no previous file with comments | « gpu/tools/compositor_model_bench/shaders.cc ('k') | ios/chrome/common/string_util.mm » ('j') | url/gurl.h » ('J')