Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: gpu/tools/compositor_model_bench/shaders.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/tools/compositor_model_bench/shaders.cc
diff --git a/gpu/tools/compositor_model_bench/shaders.cc b/gpu/tools/compositor_model_bench/shaders.cc
index 5559e73a558d526707ef18b7298739b8fbdb43c3..66f5aac63e2b4cfbeeb4a4b84678edec22cc751e 100644
--- a/gpu/tools/compositor_model_bench/shaders.cc
+++ b/gpu/tools/compositor_model_bench/shaders.cc
@@ -81,7 +81,7 @@ static void TranslateInPlace(float* m, float tx, float ty, float tz) {
///////////////////////////////////////////////////////////////////////////////
-ShaderID ShaderIDFromString(std::string name) {
+ShaderID ShaderIDFromString(const std::string& name) {
if (name == "VertexShaderPosTexYUVStretch")
return VERTEX_SHADER_POS_TEX_YUV_STRETCH;
if (name == "VertexShaderPosTex")

Powered by Google App Engine
This is Rietveld 408576698