gpu/tools/compositor_model_bench/shaders.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/tools/compositor_model_bench/shaders.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gpu/tools/compositor_model_bench/shaders.h

diff --git a/gpu/tools/compositor_model_bench/shaders.h b/gpu/tools/compositor_model_bench/shaders.h

index 459403542fd061b994277f6245a5df0fe3a3afb2..5aece20060a0248b9c734f645b250a4f931f71c4 100644

--- a/gpu/tools/compositor_model_bench/shaders.h

+++ b/gpu/tools/compositor_model_bench/shaders.h

@@ -26,7 +26,7 @@ enum ShaderID {

SHADER_ID_MAX

};

-ShaderID ShaderIDFromString(std::string name);

+ShaderID ShaderIDFromString(const std::string& name);

std::string ShaderNameFromID(ShaderID id);

void ConfigAndActivateShaderForNode(CCNode* n);

« no previous file with comments | « gpu/tools/compositor_model_bench/render_tree.cc ('k') | gpu/tools/compositor_model_bench/shaders.cc » ('j') | url/gurl.h » ('J')