components/test_runner/test_runner.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/test_runner.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/test_runner/test_runner.h

diff --git a/components/test_runner/test_runner.h b/components/test_runner/test_runner.h

index b8f6284c647c9fc115f4e31938a89e6d1ab6f870..81a10255a7681bd188f654220d352b507b0671d4 100644

--- a/components/test_runner/test_runner.h

+++ b/components/test_runner/test_runner.h

@@ -87,7 +87,7 @@ class TestRunner : public WebTestRunner,

void ClearDevToolsLocalStorage();

void setShouldDumpAsText(bool);

void setShouldDumpAsMarkup(bool);

- void setCustomTextOutput(std::string text);

+ void setCustomTextOutput(const std::string& text);

void setShouldGeneratePixelResults(bool);

void setShouldDumpFrameLoadCallbacks(bool);

void setShouldDumpPingLoaderCallbacks(bool);

@@ -329,7 +329,7 @@ class TestRunner : public WebTestRunner,

void SetXSSAuditorEnabled(bool enabled);

void SetAllowUniversalAccessFromFileURLs(bool allow);

void SetAllowFileAccessFromFileURLs(bool allow);

- void OverridePreference(const std::string key, v8::Local<v8::Value> value);

+ void OverridePreference(const std::string& key, v8::Local<v8::Value> value);

// Modify accept_languages in RendererPreferences.

void SetAcceptLanguages(const std::string& accept_languages);

« no previous file with comments | « components/sync_driver/tab_node_pool.cc ('k') | components/test_runner/test_runner.cc » ('j') | url/gurl.h » ('J')