Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: components/sync_driver/tab_node_pool.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_driver/tab_node_pool.cc
diff --git a/components/sync_driver/tab_node_pool.cc b/components/sync_driver/tab_node_pool.cc
index e3f611961fef497d33087e7374aaf7fc17cf50f4..ee6278ca4a296bf372a1cc1588fbdf0a6393fb8c 100644
--- a/components/sync_driver/tab_node_pool.cc
+++ b/components/sync_driver/tab_node_pool.cc
@@ -28,8 +28,8 @@ const int TabNodePool::kInvalidTabNodeID = -1;
TabNodePool::~TabNodePool() {}
// Static
-std::string TabNodePool::TabIdToTag(
- const std::string machine_tag, int tab_node_id) {
+std::string TabNodePool::TabIdToTag(const std::string& machine_tag,
+ int tab_node_id) {
return base::StringPrintf("%s %d", machine_tag.c_str(), tab_node_id);
}

Powered by Google App Engine
This is Rietveld 408576698