Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Side by Side Diff: components/test_runner/test_runner.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_TEST_RUNNER_TEST_RUNNER_H_ 5 #ifndef COMPONENTS_TEST_RUNNER_TEST_RUNNER_H_
6 #define COMPONENTS_TEST_RUNNER_TEST_RUNNER_H_ 6 #define COMPONENTS_TEST_RUNNER_TEST_RUNNER_H_
7 7
8 #include <deque> 8 #include <deque>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 std:: string customDumpText() const; 80 std:: string customDumpText() const;
81 bool shouldDumpAsMarkup(); 81 bool shouldDumpAsMarkup();
82 bool shouldDumpChildFrameScrollPositions() const; 82 bool shouldDumpChildFrameScrollPositions() const;
83 bool shouldDumpChildFramesAsMarkup() const; 83 bool shouldDumpChildFramesAsMarkup() const;
84 bool shouldDumpChildFramesAsText() const; 84 bool shouldDumpChildFramesAsText() const;
85 void ShowDevTools(const std::string& settings, 85 void ShowDevTools(const std::string& settings,
86 const std::string& frontend_url); 86 const std::string& frontend_url);
87 void ClearDevToolsLocalStorage(); 87 void ClearDevToolsLocalStorage();
88 void setShouldDumpAsText(bool); 88 void setShouldDumpAsText(bool);
89 void setShouldDumpAsMarkup(bool); 89 void setShouldDumpAsMarkup(bool);
90 void setCustomTextOutput(std::string text); 90 void setCustomTextOutput(const std::string& text);
91 void setShouldGeneratePixelResults(bool); 91 void setShouldGeneratePixelResults(bool);
92 void setShouldDumpFrameLoadCallbacks(bool); 92 void setShouldDumpFrameLoadCallbacks(bool);
93 void setShouldDumpPingLoaderCallbacks(bool); 93 void setShouldDumpPingLoaderCallbacks(bool);
94 void setShouldEnableViewSource(bool); 94 void setShouldEnableViewSource(bool);
95 bool shouldDumpEditingCallbacks() const; 95 bool shouldDumpEditingCallbacks() const;
96 bool shouldDumpFrameLoadCallbacks() const; 96 bool shouldDumpFrameLoadCallbacks() const;
97 bool shouldDumpPingLoaderCallbacks() const; 97 bool shouldDumpPingLoaderCallbacks() const;
98 bool shouldDumpUserGestureInFrameLoadCallbacks() const; 98 bool shouldDumpUserGestureInFrameLoadCallbacks() const;
99 bool shouldDumpTitleChanges() const; 99 bool shouldDumpTitleChanges() const;
100 bool shouldDumpIconChanges() const; 100 bool shouldDumpIconChanges() const;
(...skipping 221 matching lines...) Expand 10 before | Expand all | Expand 10 after
322 /////////////////////////////////////////////////////////////////////////// 322 ///////////////////////////////////////////////////////////////////////////
323 // Methods modifying WebPreferences. 323 // Methods modifying WebPreferences.
324 324
325 // Set the WebPreference that controls webkit's popup blocking. 325 // Set the WebPreference that controls webkit's popup blocking.
326 void SetPopupBlockingEnabled(bool block_popups); 326 void SetPopupBlockingEnabled(bool block_popups);
327 327
328 void SetJavaScriptCanAccessClipboard(bool can_access); 328 void SetJavaScriptCanAccessClipboard(bool can_access);
329 void SetXSSAuditorEnabled(bool enabled); 329 void SetXSSAuditorEnabled(bool enabled);
330 void SetAllowUniversalAccessFromFileURLs(bool allow); 330 void SetAllowUniversalAccessFromFileURLs(bool allow);
331 void SetAllowFileAccessFromFileURLs(bool allow); 331 void SetAllowFileAccessFromFileURLs(bool allow);
332 void OverridePreference(const std::string key, v8::Local<v8::Value> value); 332 void OverridePreference(const std::string& key, v8::Local<v8::Value> value);
333 333
334 // Modify accept_languages in RendererPreferences. 334 // Modify accept_languages in RendererPreferences.
335 void SetAcceptLanguages(const std::string& accept_languages); 335 void SetAcceptLanguages(const std::string& accept_languages);
336 336
337 // Enable or disable plugins. 337 // Enable or disable plugins.
338 void SetPluginsEnabled(bool enabled); 338 void SetPluginsEnabled(bool enabled);
339 339
340 /////////////////////////////////////////////////////////////////////////// 340 ///////////////////////////////////////////////////////////////////////////
341 // Methods that modify the state of TestRunner 341 // Methods that modify the state of TestRunner
342 342
(...skipping 490 matching lines...) Expand 10 before | Expand all | Expand 10 after
833 bool use_mock_theme_; 833 bool use_mock_theme_;
834 834
835 base::WeakPtrFactory<TestRunner> weak_factory_; 835 base::WeakPtrFactory<TestRunner> weak_factory_;
836 836
837 DISALLOW_COPY_AND_ASSIGN(TestRunner); 837 DISALLOW_COPY_AND_ASSIGN(TestRunner);
838 }; 838 };
839 839
840 } // namespace test_runner 840 } // namespace test_runner
841 841
842 #endif // COMPONENTS_TEST_RUNNER_TEST_RUNNER_H_ 842 #endif // COMPONENTS_TEST_RUNNER_TEST_RUNNER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698