Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Side by Side Diff: components/sync_driver/device_info.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_SYNC_DRIVER_DEVICE_INFO_H_ 5 #ifndef COMPONENTS_SYNC_DRIVER_DEVICE_INFO_H_
6 #define COMPONENTS_SYNC_DRIVER_DEVICE_INFO_H_ 6 #define COMPONENTS_SYNC_DRIVER_DEVICE_INFO_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 // Gets the device type in string form. 61 // Gets the device type in string form.
62 std::string GetDeviceTypeString() const; 62 std::string GetDeviceTypeString() const;
63 63
64 // Compares this object's fields with another's. 64 // Compares this object's fields with another's.
65 bool Equals(const DeviceInfo& other) const; 65 bool Equals(const DeviceInfo& other) const;
66 66
67 // Apps can set ids for a device that is meaningful to them but 67 // Apps can set ids for a device that is meaningful to them but
68 // not unique enough so the user can be tracked. Exposing |guid| 68 // not unique enough so the user can be tracked. Exposing |guid|
69 // would lead to a stable unique id for a device which can potentially 69 // would lead to a stable unique id for a device which can potentially
70 // be used for tracking. 70 // be used for tracking.
71 void set_public_id(std::string id); 71 void set_public_id(const std::string& id);
72 72
73 // Converts the |DeviceInfo| values to a JS friendly DictionaryValue, 73 // Converts the |DeviceInfo| values to a JS friendly DictionaryValue,
74 // which extension APIs can expose to third party apps. 74 // which extension APIs can expose to third party apps.
75 base::DictionaryValue* ToValue(); 75 base::DictionaryValue* ToValue();
76 76
77 private: 77 private:
78 const std::string guid_; 78 const std::string guid_;
79 79
80 const std::string client_name_; 80 const std::string client_name_;
81 81
(...skipping 10 matching lines...) Expand all
92 // ids in that the same device will have different id for different apps 92 // ids in that the same device will have different id for different apps
93 // and they are also reset when app/extension is uninstalled. 93 // and they are also reset when app/extension is uninstalled.
94 std::string public_id_; 94 std::string public_id_;
95 95
96 DISALLOW_COPY_AND_ASSIGN(DeviceInfo); 96 DISALLOW_COPY_AND_ASSIGN(DeviceInfo);
97 }; 97 };
98 98
99 } // namespace sync_driver 99 } // namespace sync_driver
100 100
101 #endif // COMPONENTS_SYNC_DRIVER_DEVICE_INFO_H_ 101 #endif // COMPONENTS_SYNC_DRIVER_DEVICE_INFO_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698