components/signin/core/browser/about_signin_internals.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/signin/core/browser/about_signin_internals.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/signin/core/browser/about_signin_internals.cc

diff --git a/components/signin/core/browser/about_signin_internals.cc b/components/signin/core/browser/about_signin_internals.cc

index 1e2c98212babf5796b196ecb516b565359e777e2..514f1bf002ec134fe17e8e2d330df3fd8364ce04 100644

--- a/components/signin/core/browser/about_signin_internals.cc

+++ b/components/signin/core/browser/about_signin_internals.cc

@@ -343,11 +343,12 @@ void AboutSigninInternals::OnTokenRemoved(

NotifyObservers();

}

-void AboutSigninInternals::OnRefreshTokenReceived(std::string status) {

+void AboutSigninInternals::OnRefreshTokenReceived(const std::string& status) {

NotifySigninValueChanged(REFRESH_TOKEN_RECEIVED, status);

}

-void AboutSigninInternals::OnAuthenticationResultReceived(std::string status) {

+void AboutSigninInternals::OnAuthenticationResultReceived(

+ const std::string& status) {

NotifySigninValueChanged(AUTHENTICATION_RESULT_RECEIVED, status);

}

« no previous file with comments | « components/signin/core/browser/about_signin_internals.h ('k') | components/signin/core/browser/account_fetcher_service.cc » ('j') | url/gurl.h » ('J')