Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/signin/core/browser/about_signin_internals.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/search_engines/template_url_parser_unittest.cc ('k') | components/signin/core/browser/about_signin_internals.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/signin/core/browser/about_signin_internals.h
diff --git a/components/signin/core/browser/about_signin_internals.h b/components/signin/core/browser/about_signin_internals.h
index 55e4de6d5ed73fa26a28b93b4a358037f8e24dbc..7e0dca5974b2d1f37c5beee9cece217dfb540b9b 100644
--- a/components/signin/core/browser/about_signin_internals.h
+++ b/components/signin/core/browser/about_signin_internals.h
@@ -73,8 +73,8 @@ class AboutSigninInternals
void Initialize(SigninClient* client);
- void OnRefreshTokenReceived(std::string status);
- void OnAuthenticationResultReceived(std::string status);
+ void OnRefreshTokenReceived(const std::string& status);
+ void OnAuthenticationResultReceived(const std::string& status);
// KeyedService implementation.
void Shutdown() override;
« no previous file with comments | « components/search_engines/template_url_parser_unittest.cc ('k') | components/signin/core/browser/about_signin_internals.cc » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698