Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: components/signin/core/browser/account_fetcher_service.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/account_fetcher_service.cc
diff --git a/components/signin/core/browser/account_fetcher_service.cc b/components/signin/core/browser/account_fetcher_service.cc
index 139ad28b4dccbfbc995725ae2f2ad7731bcc1275..22c804f6b496723a0a935e75abe82b37765e7d51 100644
--- a/components/signin/core/browser/account_fetcher_service.cc
+++ b/components/signin/core/browser/account_fetcher_service.cc
@@ -105,7 +105,7 @@ void AccountFetcherService::EnableNetworkFetches() {
// If there are accounts in |pending_user_info_fetches_|, they were deemed
// invalid after being loaded from prefs and need to be fetched now instead of
// waiting after the timer.
- for (std::string account_id : pending_user_info_fetches_)
+ for (const std::string& account_id : pending_user_info_fetches_)
StartFetchingUserInfo(account_id);
pending_user_info_fetches_.clear();

Powered by Google App Engine
This is Rietveld 408576698