components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/login_database_unittest.cc ('k') | components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h

diff --git a/components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h b/components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h

index 2a916caafece4280f5da92965cc4de391c2cbda9..91ee6ec99a9f2d3986324f5b7206d6bb6c35a4c2 100644

--- a/components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h

+++ b/components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h

@@ -126,7 +126,7 @@ class BluetoothLowEnergyConnectionFinder

void InvokeCallbackAsync();

// Returns the device with |device_address|.

- device::BluetoothDevice* GetDevice(std::string device_address);

+ device::BluetoothDevice* GetDevice(const std::string& device_address);

// The remote BLE device being searched. It maybe empty, in this case the

// remote device should advertise |remote_service_uuid_| and