components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h ('k') | components/search_engines/default_search_manager_unittest.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc

diff --git a/components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc b/components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc

index acc530ae437f1d05a2932c799693dab28048b0d7..5f8f86055c0a0ffaf00c9fb2d6de8a8c3e7a8753 100644

--- a/components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc

+++ b/components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc

@@ -314,7 +314,7 @@ void BluetoothLowEnergyConnectionFinder::RestartDiscoverySessionWhenReady() {

}

BluetoothDevice* BluetoothLowEnergyConnectionFinder::GetDevice(

- std::string device_address) {

+ const std::string& device_address) {

// It's not possible to simply use

// |adapter_->GetDevice(GetRemoteDeviceAddress())| to find the device with MAC

// address |GetRemoteDeviceAddress()|. For paired devices,