components/password_manager/core/browser/login_database_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/login_database_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/network_hints/renderer/dns_prefetch_queue.h ('k') | components/proximity_auth/ble/bluetooth_low_energy_connection_finder.h » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/login_database_unittest.cc

diff --git a/components/password_manager/core/browser/login_database_unittest.cc b/components/password_manager/core/browser/login_database_unittest.cc

index 26285aeccaea08420db97301372a5d9cb25d060b..2868f813196ee138e32763b58271f18018bebe5b 100644

--- a/components/password_manager/core/browser/login_database_unittest.cc

+++ b/components/password_manager/core/browser/login_database_unittest.cc

@@ -1371,7 +1371,8 @@ class LoginDatabaseMigrationTest : public testing::TestWithParam<int> {

// Returns an empty vector on failure. Otherwise returns values in the column

// |column_name| of the logins table. The order of the

// returned rows is well-defined.

- template <class T> std::vector<T> GetValues(std::string column_name) {

+ template <class T>

+ std::vector<T> GetValues(const std::string& column_name) {

sql::Connection db;

std::vector<T> results;

if (!db.Open(database_path_))