components/search_engines/default_search_manager_unittest.cc - Issue 1349783006: Cleanup: Pass std::string as const reference if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/default_search_manager_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert third_party changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/proximity_auth/ble/bluetooth_low_energy_connection_finder.cc ('k') | components/search_engines/template_url_parser_unittest.cc » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/search_engines/default_search_manager_unittest.cc

diff --git a/components/search_engines/default_search_manager_unittest.cc b/components/search_engines/default_search_manager_unittest.cc

index 6687ba3c9f9b8e5d74575f0512937fd1a560af66..df60ee5fce971935d580f34e7357e728c43a0fa1 100644

--- a/components/search_engines/default_search_manager_unittest.cc

+++ b/components/search_engines/default_search_manager_unittest.cc

@@ -118,7 +118,8 @@ void SetPolicy(user_prefs::TestingPrefServiceSyncable* prefs,

prefs->SetManagedPref(kDefaultSearchProviderData, entry.release());

}

-scoped_ptr<TemplateURLData> GenerateDummyTemplateURLData(std::string type) {

+scoped_ptr<TemplateURLData> GenerateDummyTemplateURLData(

+ const std::string& type) {

scoped_ptr<TemplateURLData> data(new TemplateURLData());

data->SetShortName(base::UTF8ToUTF16(std::string(type).append("name")));

data->SetKeyword(base::UTF8ToUTF16(std::string(type).append("key")));