Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Unified Diff: components/metrics/cloned_install_detector.h

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/cloned_install_detector.h
diff --git a/components/metrics/cloned_install_detector.h b/components/metrics/cloned_install_detector.h
index 065cb490c507307d33cfaf320429a43ccf6e112f..3ff7558941a74b0cfe3d789f7fe9962da017afaa 100644
--- a/components/metrics/cloned_install_detector.h
+++ b/components/metrics/cloned_install_detector.h
@@ -46,7 +46,7 @@ class ClonedInstallDetector {
// Converts raw_id into a 24-bit hash and stores the hash in |local_state|.
// |raw_id| is not a const ref because it's passed from a cross-thread post
// task.
- void SaveMachineId(PrefService* local_state, std::string raw_id);
+ void SaveMachineId(PrefService* local_state, const std::string& raw_id);
scoped_refptr<MachineIdProvider> raw_id_provider_;
base::WeakPtrFactory<ClonedInstallDetector> weak_ptr_factory_;

Powered by Google App Engine
This is Rietveld 408576698