Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: components/metrics/cloned_install_detector.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/cloned_install_detector.cc
diff --git a/components/metrics/cloned_install_detector.cc b/components/metrics/cloned_install_detector.cc
index 16598b4c2995a2d86f31efc6bf47217a3754452a..b9dc25c5bc6acd4c5a6dfd3ac5f70eb03bd40ea4 100644
--- a/components/metrics/cloned_install_detector.cc
+++ b/components/metrics/cloned_install_detector.cc
@@ -65,7 +65,7 @@ void ClonedInstallDetector::CheckForClonedInstall(
}
void ClonedInstallDetector::SaveMachineId(PrefService* local_state,
- std::string raw_id) {
+ const std::string& raw_id) {
if (raw_id.empty()) {
LogMachineIdState(ID_GENERATION_FAILED);
local_state->ClearPref(prefs::kMetricsMachineId);

Powered by Google App Engine
This is Rietveld 408576698