Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/invalidation/impl/gcm_network_channel_unittest.cc

Issue 1349783006: Cleanup: Pass std::string as const reference if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert third_party changes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/gcm_driver/gcm_stats_recorder_impl.cc ('k') | components/metrics/cloned_install_detector.h » ('j') | url/gurl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/invalidation/impl/gcm_network_channel_unittest.cc
diff --git a/components/invalidation/impl/gcm_network_channel_unittest.cc b/components/invalidation/impl/gcm_network_channel_unittest.cc
index e07788e5e0d5d88a35f7ec9795d791b60b252899..e0597f8eebbd5a3682476cffa2fe52e4c5bbd411 100644
--- a/components/invalidation/impl/gcm_network_channel_unittest.cc
+++ b/components/invalidation/impl/gcm_network_channel_unittest.cc
@@ -170,8 +170,7 @@ class GCMNetworkChannelTest
last_invalidator_state_ = invalidator_state;
}
- void OnIncomingMessage(std::string incoming_message) {
- }
+ void OnIncomingMessage(std::string /* incoming_message */) {}
GCMNetworkChannel* network_channel() {
return gcm_network_channel_.get();
« no previous file with comments | « components/gcm_driver/gcm_stats_recorder_impl.cc ('k') | components/metrics/cloned_install_detector.h » ('j') | url/gurl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698